Skip to content

Add regression test for graph paths with spaces#3087

Open
brosequist wants to merge 1 commit intoalicevision:developfrom
brosequist:codex/regression-test-spaced-graph-path
Open

Add regression test for graph paths with spaces#3087
brosequist wants to merge 1 commit intoalicevision:developfrom
brosequist:codex/regression-test-spaced-graph-path

Conversation

@brosequist
Copy link
Copy Markdown

Summary

  • add a regression test for isolated node compute command construction when the graph filepath contains spaces
  • verify the generated command keeps the .mg path as one argument after shell-style parsing

Context

The runtime fix for graph paths with spaces is already present on develop in commit da05aae and included in v2025.1.1+. This test protects against regressing the failure reported in #3016, where meshroom_compute received the project path split into extra arguments.

Tests

  • pytest tests/test_compute.py -k processChunkInEnvironment_quotesGraphFilepathWithSpaces
  • pytest tests/test_compute.py

@brosequist brosequist marked this pull request as ready for review April 29, 2026 20:17
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.57%. Comparing base (a4ffad7) to head (0617fd4).
⚠️ Report is 11 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3087      +/-   ##
===========================================
+ Coverage    83.47%   83.57%   +0.09%     
===========================================
  Files           81       81              
  Lines        10301    10319      +18     
===========================================
+ Hits          8599     8624      +25     
+ Misses        1702     1695       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant